Multiplayer: implement drop user function#4854
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements ENet user dropping so lobby/login rejection paths can actually disconnect peers and notify the network layer instead of hitting the previous stub.
Changes:
- Replaces the
bf_enet_drop_userstub with queue cleanup, peer disconnect, and drop callback dispatch. - Uses the existing peer-to-user-id mapping to find and disconnect the matching ENet peer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a blind fix, but according to a log that was provided after hitting
"bf_enet_drop_user: enet_drop_user not implemented"the frontend would rapidly switch betweenFeSt_NET_STARTandFeSt_MP_MAPPACK_SELECTin a permanent loop. It seems a fairly straightforward fix, just implement enet_drop_user.